Merged
Conversation
StefH
requested changes
Nov 25, 2018
Collaborator
StefH
left a comment
There was a problem hiding this comment.
some minor textual changes
| if (!_parsingConfig.DisableMemberAccessToIndexAccesorDowncast) | ||
| { | ||
| return Expression.Call(instance, indexerMethod, Expression.Constant(id)); | ||
| MethodInfo indexerMethod = instance.Type.GetMethod("get_Item", new[] {typeof(string)}); |
Collaborator
There was a problem hiding this comment.
missing some spaces here, did you do a format-file?
| public bool RenameParameterExpression { get; set; } = false; | ||
|
|
||
| /// <summary> | ||
| /// By default when a member is not found in a type and the type has a string bassed index accessor it will be parsed as an index accesor. Use |
| public bool RenameParameterExpression { get; set; } = false; | ||
|
|
||
| /// <summary> | ||
| /// By default when a member is not found in a type and the type has a string bassed index accessor it will be parsed as an index accesor. Use |
| /// <summary> | ||
| /// By default when a member is not found in a type and the type has a string bassed index accessor it will be parsed as an index accesor. Use | ||
| /// this flag to disable this behaviour and have parsing fail when parsing an expression | ||
| /// where a member access on a non existing member happens |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// where a member access on a non existing member happens | |
| /// where a member access on a non existing member happens. Default value is false. |
Collaborator
|
It seems I did forget the CI Pull Request build integration with Azure Pipelines. I did change this and I hope that when you push new code, the build will trigger... |
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 96.63% 96.63% +<.01%
==========================================
Files 41 41
Lines 6648 6654 +6
==========================================
+ Hits 6424 6430 +6
Misses 224 224
Continue to review full report at Codecov.
|
StefH
reviewed
Nov 25, 2018
| public bool RenameParameterExpression { get; set; } = false; | ||
|
|
||
| /// <summary> | ||
| /// By default when a member is not found in a type and the type has a string based index accessor it will be parsed as an index accesor. Use |
Collaborator
|
1 more typo in still a typo in |
Contributor
Author
|
Fixed the typo in accessor, still not sure what the typo in "based" is. |
StefH
approved these changes
Nov 25, 2018
Collaborator
|
all ok |
Collaborator
|
linked to #215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 Changes in this PR.
DynamicClassFactory.cs no longer creates a parameter constructor when the class has no properties. Prior to this, a class with a duplicate empty constructor was created.
Added DisableMemberAccessToIndexAccessorFallback to disable automatic downcast/fallback to item accesor when a member is not found. This is an enhancement for developers because it helps early detection of badly created expressions that will fail to evaluate. Previous behaviour is respected as this is a new optional flag.